From e6817ea263e65f50f74d1c66a575f3ec21f36497 Mon Sep 17 00:00:00 2001 From: Patrick Date: Fri, 1 Nov 2024 14:35:15 -0400 Subject: [PATCH] moving step error metric out of isFullyProcessed (#15071) --- core/services/workflows/engine.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/services/workflows/engine.go b/core/services/workflows/engine.go index 142ca49f369..cdcc7909d36 100644 --- a/core/services/workflows/engine.go +++ b/core/services/workflows/engine.go @@ -611,6 +611,7 @@ func (e *Engine) handleStepUpdate(ctx context.Context, stepUpdate store.Workflow l.Info("workflow finished") case store.StatusErrored: l.Info("execution errored") + e.metrics.incrementTotalWorkflowStepErrorsCounter(ctx) case store.StatusCompletedEarlyExit: l.Info("execution terminated early") // NOTE: even though this marks the workflow as completed, any branches of the DAG @@ -985,7 +986,6 @@ func (e *Engine) isWorkflowFullyProcessed(ctx context.Context, state store.Workf } } } - e.metrics.incrementTotalWorkflowStepErrorsCounter(ctx) } return nil })