-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data race in PersistenceManager tests #10394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any README files. Would it make sense to do so? |
Related: #10367 |
samsondav
previously approved these changes
Aug 30, 2023
samsondav
approved these changes
Aug 30, 2023
jmank88
approved these changes
Aug 30, 2023
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6104183299 |
SonarQube Quality Gate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stab at fixing a data race in the PersistenceManager's tests:
The line numbers don't match up with
develop
branch anymore, but I believe the race is on the package levelmaxTransmitQueueSize
variable being written to in theTestPersistenceManagerPrune
test and then read in therunPruneLoop
func. This race condition is an artifact of how the test is set up and shouldn't affect prod.The attempted fix in this PR is to pass this and 2 other values into the PersistenceManager rather than have it read from global variables that are modified by tests, thus removing the 'write' condition. I wasn't able to successfully repro the data race locally, but this should fix the issue in theory.