Remove Explorer #10581
Remove Explorer #10581
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149371589 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149836498 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6150202642 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6150461651 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6150606214 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6150813424 |
skubakdj
requested review from
jkongie,
jmank88,
samsondav and
prashantkumar1982
as code owners
docs/CHANGELOG.md
Outdated
| @@ -27,6 +27,10 @@ AllowSimplePasswords=true | |||
|
|
|||
| - To migrate on production builds, update the database password set in Database.URL to be 16 - 50 characters without leading or trailing whitespace. URI parsing rules apply to the chosen password - refer to [RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986) for special character escape rules. | |||
|
|
|||
| ### Removed | |||
|
|
|||
| - Removed support for sending telemetry to the deprecated Explorer service | |||
There was a problem hiding this comment.
We should probably be explicit here about the config fields that are being removed and that node ops must remove them, since the node will reject a config that still has them and refuse to start.
There was a problem hiding this comment.
@jmank88 I just updated the changelog, could you please take a look?
| ticfg := cfg.TelemetryIngress() | ||
| // Use Explorer over TelemetryIngress if both URLs are set | ||
| if cfg.Explorer().URL() == nil && ticfg.URL() != nil { | ||
| if ticfg.URL() != nil { | ||
| if ticfg.UseBatchSend() { | ||
| telemetryIngressBatchClient = synchronization.NewTelemetryIngressBatchClient(ticfg.URL(), |
There was a problem hiding this comment.
unrelated to the scope of this PR, but this is a pretty heavy API w/ a large number of the parameters coming from cfg.TelemetryIngress() - what do you think of plumbing ticfg as one parameter through instead?
There was a problem hiding this comment.
sounds good to me, that would definitely clean things up a bit 🙂
| @@ -129,10 +129,6 @@ func (s *Secrets) SetFrom(f *Secrets) (err error) { | |||
| err = multierr.Append(err, config.NamedMultiErrorList(err1, "Database")) | |||
| } | |||
|
|
|||
| if err2 := s.Explorer.SetFrom(&f.Explorer); err2 != nil { | |||
There was a problem hiding this comment.
/nit and a matter of preference - in the future when I revisit this file I'd spend some unnecessary time answering the question "why is err2 skipped?". If you'd like, perhaps update the ordering here
There was a problem hiding this comment.
@patrickhuie19 just pushed a commit for this
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
As Explorer has been deprecated, this PR: