core/services: health Checker cleanup #10670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
commented
Sep 17, 2023
Comment on lines
-484
to
-493
| // To avoid subscribing chain services twice, we only subscribe them if OCR2 is not enabled. | ||
| // If it's enabled, they are going to be registered with relayers by default. | ||
| if !cfg.OCR2().Enabled() { | ||
| for _, service := range app.relayers.Services() { | ||
| checkable := service.(services.Checkable) | ||
| if err := app.HealthChecker.Register(service.Name(), checkable); err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This exception is no longer required since the relayer services are now added unconditionally.
jmank88
commented
Sep 17, 2023
Comment on lines
+444
to
+446
| healthChecker := services.NewChecker() | ||
| for _, s := range srvcs { | ||
| if err := healthChecker.Register(s); err != nil { |
There was a problem hiding this comment.
Relocated and simplified - no need to cast.
jmank88
commented
Sep 17, 2023
| @@ -176,7 +176,8 @@ func (c *checker) update() { | |||
| uptimeSeconds.Add(interval.Seconds()) | |||
| } | |||
|
|
|||
| func (c *checker) Register(name string, service Checkable) error { | |||
| func (c *checker) Register(service Checkable) error { | |||
There was a problem hiding this comment.
Outside of tests, we only check ServiceCtxs, so every Checkable implementation already had a Name() method. Now that method is defined on Checkable instead of ServiceCtx.
jmank88
force-pushed
the
health-check-cleanup
branch
from
86104ca to
9f2e0dd
Compare
jmank88
force-pushed
the
health-check-cleanup
branch
from
0005629 to
ce4b6c7
Compare
|
SonarQube Quality Gate
|
patrickhuie19
approved these changes
Sep 18, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
krehermann
approved these changes
Sep 18, 2023
krehermann
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some services were added to the health checker twice, and then found some simplifications while cleaning it up.