bump chainlink-common for SLOW QUERY log updates and custom thresholds #13358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
0a71680 to
1251422
Compare
|
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
1251422 to
99b45e5
Compare
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
99b45e5 to
7bd99d9
Compare
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
7bd99d9 to
affd637
Compare
jmank88
changed the title
jmank88
commented
Jun 5, 2024
Comment on lines
+225
to
+231
| overtimeThresholds = sqlutil.LogThresholds{ | ||
| Warn: func(timeout time.Duration) time.Duration { | ||
| return timeout - (timeout / 5) // 80% | ||
| }, | ||
| Error: func(timeout time.Duration) time.Duration { | ||
| return timeout - (timeout / 10) // 90% | ||
| }, |
There was a problem hiding this comment.
These adjusted thresholds are somewhat arbitrary - do they seem OK? For reference the defaults are 10%/20%.
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
0123f15 to
7f72ade
Compare
jmank88
commented
Jun 5, 2024
| @@ -235,6 +245,7 @@ func init() { | |||
| // overtimeContext returns a modified context for overtime work, since tasks are expected to keep running and return | |||
| // results, even after context cancellation. | |||
| func overtimeContext(ctx context.Context) (context.Context, context.CancelFunc) { | |||
| ctx = overtimeThresholds.ContextWithValue(ctx) | |||
There was a problem hiding this comment.
Perhaps this should only apply to the deadline case? Because we have a longer default timeout otherwise
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
7f72ade to
3dd590d
Compare
jmank88
force-pushed
the
BCF-3245-slow-query-logs
branch
from
3dd590d to
0dd836c
Compare
samsondav
approved these changes
Jun 5, 2024
reductionista
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-3245
New version understand the difference between cancellation and a missed deadline.
https://smartcontract-it.atlassian.net/browse/BCF-3252
Use custom thresholds to reduce noisy logs when we expect to use most of a timeout.
Requires: