Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keystone] Minor fixes #14091

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[Keystone] Minor fixes #14091

merged 1 commit into from
Aug 12, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Aug 9, 2024

A bundle of minor fixes in several components:

  1. Launcher: adjust defaultStreamConfig values to a resonable max capacity (250 MB per channel)
  2. Trigger shims: change some incorrect read-locks to rw-locks
  3. Trigger shims: enforce max possible number of bundled worklflow IDs in an event
  4. Mode Aggregator: avoid unnecessary early exit
  5. Message Cache: avoid unnecessary early exit while collecting ready messages

A bundle of minor fixes in several components:
1. Launcher: adjust defaultStreamConfig values to a resonable max capacity (250 MB per channel)
2. Trigger shims: change some incorrect read-locks to rw-locks
3. Trigger shims: enforce max possible number of bundled worklflow IDs in an event
4. Mode Aggregator: avoid unnecessary early exit
5. Message Cache: avoid unnecessary early exit while collecting ready messages
@bolekk bolekk requested a review from a team August 9, 2024 20:36
@bolekk bolekk requested a review from a team as a code owner August 9, 2024 20:36
Copy link
Contributor

github-actions bot commented Aug 9, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@bolekk bolekk enabled auto-merge August 9, 2024 23:08
@bolekk bolekk added this pull request to the merge queue Aug 12, 2024
Merged via the queue into develop with commit 1fcfd80 Aug 12, 2024
113 of 114 checks passed
@bolekk bolekk deleted the bugfix/easy-ones branch August 12, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants