Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeSender relies on obsolete WebRequest.Create #37

Open
MKuenzi opened this issue Sep 11, 2023 · 0 comments
Open

NativeSender relies on obsolete WebRequest.Create #37

MKuenzi opened this issue Sep 11, 2023 · 0 comments

Comments

@MKuenzi
Copy link

MKuenzi commented Sep 11, 2023

Hi, I noticed when looking through the code that NativeSender.cs relies on WebRequest.Create to make it's Http requests.

Microsoft recommends you switch this to use HttpClient:
https://learn.microsoft.com/en-us/dotnet/api/system.net.webrequest.create?view=net-7.0#system-net-webrequest-create(system-string)

It would be nice to have an overload in your API where I can provide my own instance of HttpClient, as that class is intended to only be initialized once:

https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclient?view=net-7.0#instancing

I'm evaluating Smarty right now for use in our application. If possible I would like to know if you are on board with making these changes and what your timeframe would be for implementing them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant