fix accessibility filters

smclab · May 16, 2024 · dd4db34 · dd4db34
1 parent 5073140
commit dd4db34
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/js-packages/search-frontend/src/components/FilterCategoryDynamic.tsx b/js-packages/search-frontend/src/components/FilterCategoryDynamic.tsx
@@ -230,7 +230,7 @@ function FilterCategoryDynamic({
               />
             </div>
           )}
-          <div
+          <ul
             className="openk9-filter-form-check-container"
             css={css`
               display: flex;
@@ -261,7 +261,7 @@ function FilterCategoryDynamic({
 
               return (
                 <React.Fragment key={"fragment-filter-dynamic " + index}>
-                  <div
+                  <li
                     key={index}
                     className="form-check"
                     css={css`
@@ -387,11 +387,11 @@ function FilterCategoryDynamic({
                         )}
                       </label>
                     </span>
-                  </div>
+                  </li>
                 </React.Fragment>
               );
             })}
-          </div>
+          </ul>
           {!isUniqueLoadMore && suggestions.hasNextPage && (
             <div
               className="openk9-container-load-more"

diff --git a/js-packages/search-frontend/src/components/FiltersMobileLiveChange.tsx b/js-packages/search-frontend/src/components/FiltersMobileLiveChange.tsx
@@ -174,6 +174,7 @@ function FiltersMobileLiveChange<E>({
         }}
       >
         <FiltersMemo
+          memoryResults={memoryResults}
           searchQuery={searchQuery}
           onAddFilterToken={onAddFilterToken}
           onRemoveFilterToken={onRemoveFilterToken}
@@ -216,12 +217,6 @@ function FiltersMobileLiveChange<E>({
           }
         `}
       >
-        <div
-          css={css`
-            margin-top: 10px;
-            border: 0.5px solid #d4d4d8;
-          `}
-        ></div>
         <button
           className="openk9-filter-horizontal-submit openk9-filter-button-mobile-remove"
           aria-label={t("remove-filters") || "remove filters"}
@@ -340,6 +335,7 @@ function ViewAllTabs({
 
   return (
     <div
+      className="openk9-filter-tabs-container"
       css={css`
         margin-left: 16px;
       `}
@@ -385,15 +381,17 @@ function ViewAllTabs({
           </button>
         )}
       </div>
-      <div
+      <ul
+        className="openk9-filter-tabs-list"
         css={css`
           margin: 10px 0px;
         `}
       >
         {isOpen &&
           tabs.map((tab, index) => {
             return (
-              <div
+              <li
+                className="openk9-filter-tabs-list-item"
                 css={css`
                   display: flex;
                   gap: 10px;
@@ -438,10 +436,10 @@ function ViewAllTabs({
                     {capitalize(tab.label)}
                   </label>
                 </div>
-              </div>
+              </li>
             );
           })}
-      </div>
+      </ul>
     </div>
   );
 }