Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize PineForest less aggressively #86

Open
hombit opened this issue Jun 8, 2023 · 2 comments
Open

Optimize PineForest less aggressively #86

hombit opened this issue Jun 8, 2023 · 2 comments

Comments

@hombit
Copy link
Member

hombit commented Jun 8, 2023 •
edited
Loading

If we compare loss functions used in AADForest.fit_known() and PineForest.fit_known() we find that for the AADForest we, following the original paper, do not optimize further for samples which are already belong to there "classes" (separated by anomaly score quantile, q_tau). I propose to adopt this approach for PineForest as well
@balodja
Copy link
Collaborator

balodja commented Jun 14, 2023

At first we should formulate score function for PineForest in a precise way. It will look like something similar to minimax loss function as I see at the moment.

@matwey
Copy link
Contributor

matwey commented Jul 4, 2023

It would be great to add an argument to constructor allowing to choose between multiple proven loss functions for each algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matwey @balodja @hombit