Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAD adaptative power #75

Open
pruzhinskaya opened this issue Mar 3, 2021 · 5 comments
Open

AAD adaptative power #75

pruzhinskaya opened this issue Mar 3, 2021 · 5 comments
Assignees

Comments

@pruzhinskaya
Copy link
Collaborator

About the possibility to increase the impact of expert feedback on the AAD model.

From Shubhomoy:
https://github.com/shubhomoydas/ad_examples/blob/master/ad_examples/aad/aad_loss.py
The parameter prior_influence in the two functions (aad_loss_linear and aad_loss_gradient_linear) might help.

This parameter needs to be passed through aad_weight_update (https://github.com/shubhomoydas/ad_examples/blob/78b01e9c9502523c5341243e1a8dca6befcefbc3/ad_examples/aad/aad_base.py#L260)

@matwey matwey self-assigned this Jul 6, 2021
@matwey
Copy link
Collaborator

matwey commented Jul 6, 2021

Do you have a plan how to test it? I cannot figure out which prior influence value is big enough. By default it is 1.0.

@pruzhinskaya
Copy link
Collaborator Author

Yes, we definitely have to test it using a smaller dataset.

@matwey
Copy link
Collaborator

matwey commented Jul 6, 2021

I don't see any significant difference when running with 1.0, 10.0, and 100.0.
I use Y for all choices. Is it correct?

@pruzhinskaya
Copy link
Collaborator Author

If you say YES the model should not changed, it is changing when you say NO

@matwey
Copy link
Collaborator

matwey commented Jul 6, 2021

I suggest to discuss at the evening, that we all understand how this is going to work in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants