Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix issue 5 #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jhchung
Copy link

@jhchung jhchung commented Feb 19, 2025

This pull request introduces bug fixes to address some of the issues raised in #5

  • Fix creation of x_dict
  • Update hard-coded p-value threshold with proper function argument
  • Update adding Category to data frames that might be empty
  • Fix df_val_all concatenation steps

Bugfixs for pvalue threshold and adding category fields to empty data.frames.
Remove old line that I forgot to clean up.
Fix G2P Category name.
Remove extra dot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant