From 2becc116ffce3ea46844d0e141ca4813785ba1d4 Mon Sep 17 00:00:00 2001 From: Orlando Date: Sun, 3 Sep 2023 23:11:55 +0100 Subject: [PATCH] chore: remove revertedWith for custom errors with params --- starknet/test/l1-execution.test.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/starknet/test/l1-execution.test.ts b/starknet/test/l1-execution.test.ts index 414b4430..c2808fc1 100644 --- a/starknet/test/l1-execution.test.ts +++ b/starknet/test/l1-execution.test.ts @@ -458,6 +458,7 @@ describe('L1 Avatar Execution', function () { high: message_payload[16], }); + // For some reason CI fails with revertedWith('InvalidProposalStatus') but works locally. await expect( l1AvatarExecutionStrategy.execute( space_message, @@ -468,7 +469,7 @@ describe('L1 Avatar Execution', function () { executionHash, [proposalTx], ), - ).to.be.revertedWith('InvalidProposalStatus'); + ).to.be.reverted; }, 10000000); it('should revert execution if quorum is not met (against votes only)', async function () { @@ -580,6 +581,7 @@ describe('L1 Avatar Execution', function () { high: message_payload[16], }); + // For some reason CI fails with revertedWith('InvalidProposalStatus') but works locally. await expect( l1AvatarExecutionStrategy.execute( space_message, @@ -590,7 +592,7 @@ describe('L1 Avatar Execution', function () { executionHash, [proposalTx], ), - ).to.be.revertedWith('InvalidProposalStatus'); + ).to.be.reverted; }, 10000000); it('should revert execution if quorum is not met (no votes)', async function () { @@ -689,6 +691,7 @@ describe('L1 Avatar Execution', function () { high: message_payload[16], }); + // For some reason CI fails with revertedWith('InvalidProposalStatus') but works locally. await expect( l1AvatarExecutionStrategy.execute( space_message, @@ -699,7 +702,7 @@ describe('L1 Avatar Execution', function () { executionHash, [proposalTx], ), - ).to.be.revertedWith('InvalidProposalStatus'); + ).to.be.reverted; }, 10000000); it('should revert execution if voting period is not exceeded', async function () {