Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: event syntax #517

Merged
merged 3 commits into from
Aug 25, 2023
Merged

fix: event syntax #517

merged 3 commits into from
Aug 25, 2023

Conversation

Orland0x
Copy link
Contributor

No description provided.

@Orland0x Orland0x requested a review from pscott August 24, 2023 15:24
pscott
pscott approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok syntax updated, now we need to submit a new PR to actually try these events :p

starknet/src/space/space.cairo Outdated
AuthenticatorsAdded: AuthenticatorsAdded,
AuthenticatorsRemoved: AuthenticatorsRemoved,
MetadataURIUpdated: MetadataURIUpdated,
DAOURIUpdated: DAOURIUpdated,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelcase should be DaoUriUpdated and MetadataUriUpdated

starknet/src/space/space.cairo Show resolved Hide resolved
starknet/src/space/space.cairo Show resolved Hide resolved
@pscott pscott merged commit af2c1e6 into develop Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orland0x @pscott