Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get google-cloud-datastore onto 2.x, somehow #1115

Closed
snarfed opened this issue Feb 14, 2022 · 5 comments
Closed

Get google-cloud-datastore onto 2.x, somehow #1115

snarfed opened this issue Feb 14, 2022 · 5 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Feb 14, 2022

We use the ndb library with Cloud Datastore. It has a mandate to maintain Python 2.7 compatibility, so it has to stay on google-cloud-datastore 1.x, which in turn requires the 1.x versions of most other Python Google Cloud libraries, including google-auth, google-cloud-core, etc. Background in googleapis/python-ndb#733.

Those Google libraries are now all on 2.x or beyond, so the 1.x branches are degrading and no longer getting bug fixes, new features, or even fixes for security vulnerabilities like googleapis/python-ndb#733 (comment). That specific vulnerability doesn't apply to us, and they say they'll backport patches for any vulnerability that does, but still, it's an unfortunate position.

As downstream ndb users, what can we do about this? I'm not sure. Our ndb usage is pretty deeply entrenched in the code. We could migrate away, but that would be a significant undertaking. We could fork ndb and drop its Python 2.7 compatibility, but that's not something I want to do or maintain either.

Hrm.

@snarfed
Copy link
Owner Author

snarfed commented Apr 28, 2022

Narrowing to just google-cloud-datastore, since the rest are now on 2.x. Background in googleapis/google-cloud-python#10566 (comment).

The more worrying part from that comment is:

The current owners of the Datastore libraries team let me know that NDB is not currently being developed, but things may change in the future.

@snarfed snarfed changed the title Get google-* dependencies onto 2.x versions, somehow Get google-cloud-datastore onto 2.x, somehow Apr 28, 2022
@snarfed
Copy link
Owner Author

snarfed commented Apr 28, 2022

Asked about that in googleapis/python-ndb#765

@snarfed
Copy link
Owner Author

snarfed commented Jul 5, 2022

Community-contribute ndb fork that upgraded to datastore v2: https://github.com/jacobg/python-ndb/tree/datastore-v2

@snarfed
Copy link
Owner Author

snarfed commented Dec 4, 2022

Official PR! googleapis/python-ndb#841

@snarfed
Copy link
Owner Author

snarfed commented Dec 6, 2022

^ It's merged! Can't wait for the release.

@snarfed snarfed closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant