Skip to content

Commit

Permalink
refactor(ivc): use same types in protogalaxy & cyclefold
Browse files Browse the repository at this point in the history
**Motivation**
During the implementation of #369, the types for protogalaxy & cyclefold differed in form but not in substance

**Overview**
Simple refactoring with removing identical structures and using in ivc::cyclefold types from ivc::protogalaxy
  • Loading branch information
cyphersnake committed Dec 3, 2024
1 parent 2bc60b5 commit 9b1e411
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/ivc/cyclefold/mod.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use std::num::NonZeroUsize;
use halo2_proofs::halo2curves::ff::{FromUniformBytes, PrimeFieldBits};

use crate::{
halo2_proofs::halo2curves::ff::{FromUniformBytes, PrimeFieldBits},
main_gate::MainGateConfig,
poseidon::{poseidon_circuit::PoseidonChip, PoseidonHash, ROTrait, Spec},
};
Expand Down Expand Up @@ -39,4 +39,3 @@ pub fn ro_chip<F: PrimeFieldBits + FromUniformBytes<64>>(
) -> PoseidonChip<F, T, RATE> {
PoseidonChip::new(main_gate_config, ro_const())
}

6 changes: 5 additions & 1 deletion src/ivc/cyclefold/sfc/input/assigned.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ impl<F: PrimeField> SelfTrace<F> {
input_accumulator,
main_gate_config,
)?,
incoming: NativePlonkInstance::assign_advice_from_native(region, incoming, main_gate_config)?,
incoming: NativePlonkInstance::assign_advice_from_native(
region,
incoming,
main_gate_config,
)?,
proof: ProtogalaxyProof::assign_advice_from(region, proof, main_gate_config)?,
})
}
Expand Down

0 comments on commit 9b1e411

Please sign in to comment.