-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added autoScroll option to Carousel component #373
Conversation
Hi @mmarfat This is fantastic! Nice new feature, complete with tests and docs 🏆 I just need to look into one thing before we proceed: the upstream Mantine library currently locks the Embla Carousel dependency to V7, while the autoScroll feature you've implemented is part of V8. We'll need to check for any issues with the different versions. If we find there are compatibility concerns, no worries—we can keep this as a draft PR and revisit it as soon as Mantine catches up to you! |
Thanks @AnnMarieW. No worries. If I can help with anything please let me know. |
One thing you could do is to push the package.json file that was updated for the V8 carousel - that will ensure it will install and build without errors. |
@alexcjohnson |
@AnnMarieW where is the lock you're referring to? I just see |
Oh, that's interesting... It shows a lock in their docs: https://mantine.dev/x/carousel/ |
I don't see anything listed as a breaking change in https://github.com/davidjerleke/embla-carousel/releases/tag/v8.0.0 so this feels fairly low-risk to me. If you've tried it and don't see any issues I'd say we should accept this change. |
Thanks for the PR @mmarfat 💃 |
Description
This pull request introduces the
autoScroll
feature to the Carousel component, similar to the previously implementedautoplay
feature [#316].For more details on different options you can refer to Embla Carousel documentation.
Example Usage
An example has been provided in the docs.
If you encounter any issues or have any suggestions please let me know.