Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing timeout behavior #13

Open
daewok opened this issue Dec 8, 2021 · 0 comments
Open

Confusing timeout behavior #13

daewok opened this issue Dec 8, 2021 · 0 comments

Comments

@daewok
Copy link
Contributor

daewok commented Dec 8, 2021

The current state of timeouts in this library is confusing. There are keywords for open-serial (inherited from LW) for very fine-grained setting of timeouts (in seconds). But those are completely ignored in favor of per operation timeouts, specified in milliseconds. We should probably choose one and get rid of the other. I kind of like LW's API better here, but it would need to be extended with some functions to adjust the timeout after the serial port is opened.

Additionally, the LW API lets you control per operation if an error is signaled or some default value is returned on timeout. I think this particular behavior is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant