Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1644121: Fix build warnings #1011

Merged
merged 7 commits into from
Sep 2, 2024
Merged

SNOW-1644121: Fix build warnings #1011

merged 7 commits into from
Sep 2, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Aug 29, 2024 •
edited
Loading

Description

SNOW-1644121: Fix build warnings

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner August 29, 2024 07:27
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (60c2f2b) to head (e5be391).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   85.67%   85.62%   -0.05%     
==========================================
  Files         106      106              
  Lines       10796    10796              
  Branches     1035     1035              
==========================================
- Hits         9249     9244       -5     
- Misses       1296     1303       +7     
+ Partials      251      249       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1644121: Fix GH CI warnings SNOW-1644121: Fix build warnings Aug 29, 2024
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 8a22adb into master Sep 2, 2024
53 of 54 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1644121 branch September 2, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-knozderko @sfc-gh-mhofman