Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1569293 Read encryption headers in a case insensitive way #1067

Merged

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1569293 Read encryption headers in a case insensitive way

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner December 2, 2024 15:13
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.13%. Comparing base (6d0ba1f) to head (e2272f1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...leTransfer/StorageClient/SFSnowflakeAzureClient.cs 76.47% 2 Missing and 2 partials ⚠️
...Data/Core/FileTransfer/StorageClient/SFS3Client.cs 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
- Coverage   86.32%   86.13%   -0.20%     
==========================================
  Files         121      121              
  Lines       11821    11845      +24     
  Branches     1205     1212       +7     
==========================================
- Hits        10205    10203       -2     
- Misses       1329     1350      +21     
- Partials      287      292       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit f7201b2 into master Dec 4, 2024
50 of 52 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1569293_case_insensitive_encryption_headers branch December 4, 2024 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants