Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-715504 Fix secondary authentication data in authenticators #1086

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-715504 Fix secondary authentication data in authenticators

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner January 28, 2025 15:56
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.27%. Comparing base (7fb2dc4) to head (aa237d5).

Files with missing lines Patch % Lines
...Core/Authenticator/ExternalBrowserAuthenticator.cs 0.00% 1 Missing ⚠️
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
+ Coverage   86.22%   86.27%   +0.05%     
==========================================
  Files         131      131              
  Lines       12548    12548              
  Branches     1289     1289              
==========================================
+ Hits        10819    10826       +7     
+ Misses       1413     1405       -8     
- Partials      316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 3dda081 into master Jan 28, 2025
62 of 63 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-715504_fix_bug_in_authenticator branch January 28, 2025 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants