Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1706569: Fix file permissions #1089

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

SNOW-1706569

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 86.33540% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (cab672d) to head (20becaf).

Files with missing lines Patch % Lines
Snowflake.Data/Core/Tools/UnixOperations.cs 81.39% 8 Missing ⚠️
Snowflake.Data/Core/Tools/FileOperations.cs 92.15% 0 Missing and 4 partials ⚠️
Snowflake.Data/Core/Tools/TempUtil.cs 63.63% 3 Missing and 1 partial ⚠️
.../FileTransfer/StorageClient/SFRemoteStorageUtil.cs 50.00% 2 Missing ⚠️
Snowflake.Data/Core/Tools/DirectoryOperations.cs 85.71% 0 Missing and 2 partials ⚠️
...ager/Infrastructure/SFCredentialManagerFileImpl.cs 92.30% 0 Missing and 1 partial ⚠️
...e/FileTransfer/StorageClient/SFLocalStorageUtil.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   86.20%   86.38%   +0.18%     
==========================================
  Files         131      132       +1     
  Lines       12554    12664     +110     
  Branches     1290     1299       +9     
==========================================
+ Hits        10822    10940     +118     
+ Misses       1414     1402      -12     
- Partials      318      322       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 89d91e8 into master Jan 29, 2025
63 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1706569-file-perms branch January 29, 2025 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants