Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-189192: Use serilog instead of log4net #231

Closed
moravas opened this issue Sep 1, 2020 · 5 comments
Closed

SNOW-189192: Use serilog instead of log4net #231

moravas opened this issue Sep 1, 2020 · 5 comments
Assignees
@sfc-gh-dszmolka
Labels
feature status-triage Issue is under initial triage

Comments

@moravas
Copy link

moravas commented Sep 1, 2020

Hi,

I would like to use serilog for logging instead of log4net in my project that also depends on snowflake-connector-net too. Is it possible to inject it? Maybe, is there an example code? Thank you
@github-actions github-actions bot changed the title Use serilog instead of log4net SNOW-189192: Use serilog instead of log4net Sep 1, 2020
@RyanGrange
Copy link

If the Microsoft.Extensions.Logging interfaces were used there's plugins for both serilog and log4net and the implementer would be able to decide which logging mechanism they want to use.

@dazinator
Copy link

+1 Microsoft.Extensions.Logging is the way to go.

@dazinator
Copy link

dazinator commented Jun 30, 2022 •
edited
Loading

@sfc-gh-hkapre - Just checking - has this been done? Looking at the project readme it still says log4net is used: https://github.com/snowflakedb/snowflake-connector-net#logging

@sfc-gh-jfan sfc-gh-jfan reopened this Jul 1, 2022
@github-actions github-actions bot closed this as completed Jul 2, 2022
@sfc-gh-jfan sfc-gh-jfan reopened this Jul 6, 2022
@agilenut
Copy link

agilenut commented Sep 1, 2022

Yes. Please use Microsoft.Extensions.Logging so that you are consistent with all other modern .net libs and provide the flexibility for the consumer to choose their logging implementation of choice.

@sfc-gh-dszmolka
Copy link
Contributor

looks duplicate of #204

@sfc-gh-dszmolka sfc-gh-dszmolka closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
feature status-triage Issue is under initial triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@agilenut @dazinator @moravas @RyanGrange @sfc-gh-hkapre @SimbaGithub @sfc-gh-jfan @sfc-gh-dszmolka @sfc-gh-jhollan @sfc-gh-igarish