Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not netstandard for this library? #546

Closed
chriskallen opened this issue Oct 28, 2022 · 7 comments
Closed

Why not netstandard for this library? #546

chriskallen opened this issue Oct 28, 2022 · 7 comments
Assignees
@sfc-gh-anugupta @sfc-gh-sthyagaraj
Labels
feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@chriskallen
Copy link

chriskallen commented Oct 28, 2022 •
edited
Loading

Issue description

The library is currently targeting specific net6.0 and net472 frameworks.
This means that applications using other frameworks are not fully supported.
It also means that packages that are built on netstandard that have a dependency on Snowflake.Data get a warning

Error log

`Package 'Snowflake.Data 2.0.17' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.`

Suggested Solution

I have tested a local build of the package against netstandard2.0 and it works as expected, I cannot run the unit tests locally as the parameters.json required is encrypted.

Would just require a change to the target framework removing:

    <TargetFrameworks>net6.0;net472</TargetFrameworks>
    <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0</TargetFrameworks>

and adding:

    <TargetFrameworks>netstandard2.0</TargetFrameworks>

This is the recommended way of deploying cross platform / framework libraries:
https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/cross-platform-targeting
@sfc-gh-igarish sfc-gh-igarish assigned ghost Oct 28, 2022
@ghost ghost assigned sfc-gh-ext-simba-lf and unassigned ghost Oct 28, 2022
@jeremy-holovacs-sp
Copy link

targeting NET Standard 2.1 would be nice too.

@RyanGrange
Copy link

Currently trying to support DotNetFramework 4.8 and DotNet 6.0 applications with a common set of libraries, so we target NetStandard 2.0 in-house. There's a big push to start using the data in Snowflake directly and 2.015 (last to target standard 2.0) has been flagged by nuget.org as having vulnerabilities, so we're going to have to switch to a different Snowflake client.

@sfc-gh-dszmolka
Copy link
Contributor

Hi folks - first of all, apologies for the long period without comment on this one from the Snowflake side; we're working on making this procedure better.

Second; the request is now on the table for the product team to review and evaluate. I'll keep this thread updated with any kind of news as situation evolves. Sadly at this moment of writing, I'm not able to attach any kind of timeline to this request, but will keep you folks posted. Thank you so much for bearing with us !

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Feb 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-in_progress Issue is worked on by the driver team label Feb 22, 2024
@sfc-gh-dszmolka
Copy link
Contributor

Quick update: we started working on the request. Will keep this thread posted with the progress.

@sfc-gh-dszmolka
Copy link
Contributor

PR to support .NET Standard 2.0 in review at #867

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review and removed status-in_progress Issue is worked on by the driver team labels May 2, 2024
@sfc-gh-dszmolka
Copy link
Contributor

sfc-gh-dszmolka commented Jun 24, 2024 •
edited
Loading

PR merged and will be part of the next (major) release, i'll keep this thread posted

edit: confirming with Product team; release should be available by mid-July 2024

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Jun 24, 2024
@sfc-gh-dszmolka
Copy link
Contributor

after such a long wait, support for netstandard2.0 is now released with Snowflake .NET driver version v4.0.0 in July 2024
Thank you everyone for bearing with us !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-anugupta sfc-gh-anugupta

@sfc-gh-sthyagaraj sfc-gh-sthyagaraj

Labels
feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@chriskallen @RyanGrange @sfc-gh-dszmolka @jeremy-holovacs-sp @sfc-gh-anugupta @sfc-gh-igarish @sfc-gh-ext-simba-lf @sfc-gh-sthyagaraj