Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1814669 fix logging diagnostic info #1063

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1814669 fix logging diagnostic info

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner November 20, 2024 13:27
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.17%. Comparing base (296a281) to head (286796b).

Files with missing lines Patch % Lines
Snowflake.Data/Core/Tools/Diagnostics.cs 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage   86.32%   86.17%   -0.15%     
==========================================
  Files         121      121              
  Lines       11779    11785       +6     
  Branches     1197     1197              
==========================================
- Hits        10168    10156      -12     
- Misses       1326     1342      +16     
- Partials      285      287       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sfc-gh-knozderko sfc-gh-knozderko merged commit d212fc7 into master Nov 25, 2024
50 of 52 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1814669_fix_logging_diagnostic_info branch November 25, 2024 10:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants