Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide missing postgres variables on GCP bigquery pipeline #51

Open
adatzer opened this issue Feb 6, 2023 · 2 comments
Open

Provide missing postgres variables on GCP bigquery pipeline #51

adatzer opened this issue Feb 6, 2023 · 2 comments

Comments

@adatzer
Copy link

adatzer commented Feb 6, 2023

When setting up the default pipeline on GCP and running terraform plan with bigquery specific var-file, i.e.

terraform plan -var-file=bigquery.terraform.tfvars

there is error about missing postgres variables (Error: No value for required variable), namely for postgres_db_name, postgres_db_username, postgres_db_password. As those don't have defaults in variables.tf, a workaround was to provide dummy values for them in the bigquery tfvars file.

@lenmazzone
Copy link

I ran into the same issue in reverse -- when running terraform plan -var-file=postgres.terraform.tfvars I get:
Error: Error in function call │ │ on main.tf line 234, in locals: │ 234: bq_loader_dead_letter_bucket_name = coalesce( │ 235: join("", google_storage_bucket.bq_loader_dead_letter_bucket.*.name), │ 236: var.bigquery_loader_dead_letter_bucket_name, │ 237: ) │ ├──────────────── │ │ while calling coalesce(vals...) │ │ google_storage_bucket.bq_loader_dead_letter_bucket is empty tuple │ │ var.bigquery_loader_dead_letter_bucket_name is "" │ │ Call to function "coalesce" failed: no non-null, non-empty-string arguments.
Even though I'm not using bigquery. adding the var with a dummy value worked for me as well

@jbeemster
Copy link
Member

Hey @lenmazzone thanks for raising this - we should have a fix for this coming very soon + updates to all of the underlying GCP modules to remove deprecated functions. Watch this space!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants