-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists (ordered & unordered) don't use the correct internal Type #36
Comments
This isn't a use case I've designed the library to address, but if you'd
like to send a PR that keeps the output the same but makes the structure
more to your liking, I'm open to it.
…On Sun, Sep 17, 2017 at 8:01 PM, cimmanon ***@***.***> wrote:
I'm attempting to use this library with Heist by passing the results from
the markdown function through xmlhtml's renderHtmlNodes.
import Text.Markdown (markdown, defaultMarkdownSettings, msXssProtect)import Text.Blaze.Renderer.XmlHtml (renderHtmlNodes)
renderHtmlNodes $ markdown defaultMarkdownSettings { msXssProtect = False } "# Title\n\n* one\n* two (*foo*)\n"
The results are pretty close to what I would expect except for one little
problem: the opening and closing tags for the unordered list are in a
TextNode:
[Element {elementTag = "h1", elementAttrs = [], elementChildren = [TextNode "Title"]}
,TextNode "<ul>"
,Element {elementTag = "li", elementAttrs = [], elementChildren = [TextNode "one"]}
,Element {elementTag = "li", elementAttrs = [], elementChildren =
[TextNode "two ("
,Element {elementTag = "i", elementAttrs = [], elementChildren = [TextNode "foo"]}
,TextNode ")"
]}
,TextNode "</ul>"
]
The correct output should look like this:
[Element {elementTag = "h1", elementAttrs = [], elementChildren = [TextNode "Title"]}
,Element {elementTag = "ul", elementAttrs = [], elementChildren =
[Element {elementTag = "li", elementAttrs = [], elementChildren = TextNode "one"]}
,Element {elementTag = "li", elementAttrs = [], elementChildren = [TextNode "one"]}
,Element {elementTag = "li", elementAttrs = [], elementChildren =
[TextNode "two ("
,Element {elementTag = "i", elementAttrs = [], elementChildren = [TextNode "foo"]}
,TextNode ")"
]}
]}
]
The results are the same for both ordered and unordered lists.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#36>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADBBw81lZD6nC20VFBhQT78pkizZ4pxks5sjVBggaJpZM4PaNTb>
.
|
cimmanon
added a commit
to cimmanon/camellia-splices
that referenced
this issue
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm attempting to use this library with Heist by passing the results from the markdown function through xmlhtml's renderHtmlNodes.
The results are pretty close to what I would expect except for one little problem: the opening and closing tags for the unordered list are in a TextNode:
The correct output should look like this:
The results are the same for both ordered and unordered lists.
The text was updated successfully, but these errors were encountered: