Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Router 버그 핸들링 #30

Merged
merged 5 commits into from
Nov 17, 2023
Merged

[Patch] Router 버그 핸들링 #30

merged 5 commits into from
Nov 17, 2023

Conversation

Kangji
Copy link
Contributor

@Kangji Kangji commented Nov 16, 2023

5가지 버그 요인을 잡았습니다

Major Changes

  • create user router에서 함수 호출할 때 parameter 하나 빼먹어서 RuntimeError => 500 InternalServerError 해결
  • get all text service에서 filter 이전에 limit해서 RuntimeError => 500 해결
  • get topics router에서 typing이 잘못 표기됨 => type 안맞아서 fastapi가 500 냄 => 해결
  • get similarity에서 divbyzero 핸들링 안되어있음 => 해결
  • create intimacy에서 if else 조건 반대로 되어 있었음 => 해결

Minor Changes

Tests for the Changes

Comments

  • 다른 브랜치들 머지 이후 작업 잊지 마세요

Copy link
Contributor

@sangin514 sangin514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangin514 sangin514 merged commit bd21c0a into dev-server Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants