Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch] 정수 크기 & Not null constraint #47

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[Patch] 정수 크기 & Not null constraint #47

merged 1 commit into from
Dec 4, 2023

Conversation

Kangji
Copy link
Contributor

@Kangji Kangji commented Dec 3, 2023

Major Changes

  • Migration 파일 작성 시 not null constraint가 누락됨
  • Integer type bigint로 변경

Minor Changes

Tests for the Changes

  • TDD

Comments

@Kangji Kangji requested review from jioon1830 and sangin514 December 3, 2023 06:14
jioon1830
jioon1830 approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@jioon1830 jioon1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다!

@Kangji Kangji merged commit 569349e into dev-server Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jioon1830 jioon1830 jioon1830 approved these changes

@sangin514 sangin514 Awaiting requested review from sangin514

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kangji @jioon1830