Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Hotfix: remove zombie socket on thread/task exit #51

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

Kangji
Copy link
Contributor

@Kangji Kangji commented Dec 5, 2023

Major Changes

  • 웹소켓 리스너 task가 예기치않게 error가 발생하여 terminate하는 경우 manager에서 remove하지 않아서 좀비가 되는 문제를 async context manager로 해결
  • WebSocketDisconnect 익셉션 외에도 RuntimeError, ConnectionClosedError가 발생하는 것도 확인해서 해당 에러 try-except 핸들링

Minor Changes

Tests for the Changes

  • TDD

Comments

@Kangji Kangji requested a review from jioon1830 December 6, 2023 07:32
@gagaga42 gagaga42 self-requested a review December 9, 2023 08:23
@gagaga42 gagaga42 merged commit 70d882c into dev-server Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants