Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dummy Login feature #5

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Implement dummy Login feature #5

merged 12 commits into from
Oct 18, 2023

Conversation

peng-u-0807
Copy link
Contributor

@peng-u-0807 peng-u-0807 commented Oct 12, 2023 •
edited
Loading

수정사항

  • 로그인 화면 UI를 임시로 구현하였습니다. 계정 생성 버튼을 누르면 dummy token이 발급되어 RootView로 이동합니다.
  • Initialize and setup project #2 에 이어 hilt를 View ~ DataSource까지 적용되도록 수정하였습니다.

@peng-u-0807 peng-u-0807 changed the title Implement dummy Login UI Implement dummy Login feature Oct 12, 2023
2018JunyoungLim
2018JunyoungLim reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@2018JunyoungLim 2018JunyoungLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다!

thisisWooyeol
thisisWooyeol approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@thisisWooyeol thisisWooyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~

@dawitfamanu dawitfamanu merged commit 52e5680 into develop Oct 18, 2023
@thisisWooyeol thisisWooyeol deleted the feat/login-UI branch October 18, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2018JunyoungLim 2018JunyoungLim 2018JunyoungLim left review comments

@thisisWooyeol thisisWooyeol thisisWooyeol approved these changes

@dawitfamanu dawitfamanu Awaiting requested review from dawitfamanu

@yangchanhk98 yangchanhk98 Awaiting requested review from yangchanhk98

Assignees

@peng-u-0807 peng-u-0807

@2018JunyoungLim 2018JunyoungLim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peng-u-0807 @2018JunyoungLim @thisisWooyeol @dawitfamanu