Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/android post #83

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Test/android post #83

merged 4 commits into from
Nov 30, 2023

Conversation

thisisWooyeol
Copy link
Contributor

수정사항

  • PostViewModel에 대한 unit test를 진행하였습니다.
  • 새로 구현된 fetchMyPostList에 대한 unit test를 UseCase, Repository에도 반영하였습니다.
  • missing Singleton annotation 및 잘못된 sealed interface 선언 (PostUseCase, UserUseCase)을 수정하였습니다.

yangchanhk98
yangchanhk98 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@yangchanhk98 yangchanhk98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 머지할게요

@yangchanhk98
Copy link
Contributor

@thisisWooyeol 우열님 conflict 만 확인부탁드려요!

@thisisWooyeol thisisWooyeol merged commit db073a0 into develop Nov 30, 2023
2 checks passed
@thisisWooyeol thisisWooyeol deleted the test/android-post branch November 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangchanhk98 yangchanhk98 yangchanhk98 approved these changes

@dawitfamanu dawitfamanu Awaiting requested review from dawitfamanu

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

Assignees

@peng-u-0807 peng-u-0807

@thisisWooyeol thisisWooyeol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisWooyeol @yangchanhk98 @peng-u-0807