Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/back error message #96

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Feat/back error message #96

merged 2 commits into from
Dec 4, 2023

Conversation

yangchanhk98
Copy link
Contributor

수정사항

  • post(게시글) database에 reactions를 reactionId만 저장하는 것이 아니라 ReactionsWithEmojiUnicode(id, emoji_unicode)라는 데이터 클래스를 저장하여 이모지 유니코드를 확인할 수 있도록 하였습니다.
  • error message 들을 errorType 이란 클래스에 모두 모았습니다.

@yangchanhk98 yangchanhk98 self-assigned this Dec 4, 2023
dawitfamanu
dawitfamanu approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@dawitfamanu dawitfamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다!

@dawitfamanu dawitfamanu merged commit 8ef4b62 into develop Dec 4, 2023
2 checks passed
@thisisWooyeol thisisWooyeol deleted the feat/back-error_message branch December 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawitfamanu dawitfamanu dawitfamanu approved these changes

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

@thisisWooyeol thisisWooyeol Awaiting requested review from thisisWooyeol

Assignees

@yangchanhk98 yangchanhk98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangchanhk98 @dawitfamanu @thisisWooyeol