Skip to content

Commit

Permalink
🔀 Merge pull request #41 from snuhcs-course/hotfix/pw-qualification-s…
Browse files Browse the repository at this point in the history
…tring

Hotfix / Change pw-related string in strings.xml
  • Loading branch information
yjeong-k authored Nov 12, 2023
2 parents edb504b + ec9d7d2 commit 50d4fb0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class ResetPasswordViewModel @Inject internal constructor(
isValidPassword = false,
error = ResetPasswordError(
type = ResetPasswordErrorType.PASSWORD,
messageId = R.string.false_new_password
messageId = R.string.password_qualification
)
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class SignupViewModel @Inject internal constructor(
isValidPassword = false,
error = SignupError(
type = SignupErrorType.PASSWORD,
messageId = R.string.false_new_password
messageId = R.string.password_qualification
)
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ class SignupViewModelTest {
assertEquals(false, viewModel.uiState.value.isValidPassword)
assertEquals(false, viewModel.uiState.value.isValidEmail)
assertEquals(SignupErrorType.PASSWORD, viewModel.uiState.value.error?.type)
assertEquals(R.string.false_new_password, viewModel.uiState.value.error?.messageId)
assertEquals(R.string.password_qualification, viewModel.uiState.value.error?.messageId)
}

@Test
Expand All @@ -448,7 +448,7 @@ class SignupViewModelTest {
assertEquals(false, viewModel.uiState.value.isValidPassword)
assertEquals(false, viewModel.uiState.value.isValidEmail)
assertEquals(SignupErrorType.PASSWORD, viewModel.uiState.value.error?.type)
assertEquals(R.string.false_new_password, viewModel.uiState.value.error?.messageId)
assertEquals(R.string.password_qualification, viewModel.uiState.value.error?.messageId)
}

@Test
Expand Down

0 comments on commit 50d4fb0

Please sign in to comment.