Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/symbol selection #18

Merged
merged 28 commits into from
Nov 3, 2023
Merged

Feat/symbol selection #18

merged 28 commits into from
Nov 3, 2023

Conversation

sukchan-0811
Copy link
Contributor

@sukchan-0811 sukchan-0811 commented Nov 2, 2023

PR Title: UI & partial viewmodel implementation for symbol selection

Related Issue(s):

Link or reference any related issues or tickets.

PR Description:

  • SymbolSearchTextField: Completely well functioning, search (viewmodel & repository) yet to be implemented
  • SelectedSymbolsBox: Completely well functioning, weight table update (when clearAll() is called) yet to be implemented
  • LazyVerticalGrid: Completely well functioning
  • Symbol/CategoryUi: Partially functioning, individual operations on symbol/category (e.g. add to favorite) can be implemented with the help of viewmodel & repository
  • MaterialTheme typography labelsmall modified
  • Speechbuddy parrot resource (png) replaced with higher resolution
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@sukchan-0811 sukchan-0811 self-assigned this Nov 2, 2023
@sukchan-0811 sukchan-0811 added the frontend Feature implementation for frontend label Nov 2, 2023
@sukchan-0811 sukchan-0811 merged commit 1169c6a into main Nov 3, 2023
1 check passed
@sukchan-0811 sukchan-0811 deleted the feat/symbol-selection branch November 3, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Feature implementation for frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants