Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

상징 선택 페이지 검색 기능 향상 #39

Merged
merged 5 commits into from
Nov 12, 2023
Merged

상징 선택 페이지 검색 기능 향상 #39

merged 5 commits into from
Nov 12, 2023

Conversation

sukchan-0811
Copy link
Contributor

@sukchan-0811 sukchan-0811 commented Nov 11, 2023 •
edited by yjeong-k
Loading

PR Title: 상징 선택 페이지 검색 기능 향상

Related Issue(s):

#25

PR Description:

  • 즐겨찾기 해제 시 화면 튀는 버그 해결 (heuristic-evaluation-hotfix 브랜치에는 이미 반영돼 있었음)
  • 검색 기능 향상 (이제 어떤 모드에서 검색을 하든 모든 상징, 카테고리에 대해서 검색을 수행합니다. 즐겨찾기는 예외 - 즐겨찾기의 경우에는 여전히 즐겨찾기한 항목들에 대해서만 검색 수행)
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@sukchan-0811 sukchan-0811 added frontend Feature implementation for frontend user-interface Issues related to UI/UX labels Nov 11, 2023
@sukchan-0811 sukchan-0811 self-assigned this Nov 11, 2023
sukchan-0811 and others added 3 commits November 12, 2023 13:24
@sukchan-0811 @yjeong-k
🎨 Update frontend/app/src/main/java/com/example/speechbuddy/viewmodel…
91f285d 
…/SymbolSelectionViewModel.kt

Co-authored-by: YeonJeong Kim <[email protected]>
@sukchan-0811 @yjeong-k
🎨 Update frontend/app/src/main/java/com/example/speechbuddy/viewmodel…
c3f73e4 
…/SymbolSelectionViewModel.kt

Co-authored-by: YeonJeong Kim <[email protected]>
@sukchan-0811 @yjeong-k
🎨 Update frontend/app/src/main/java/com/example/speechbuddy/viewmodel…
a88bca3 
…/SymbolSelectionViewModel.kt

Co-authored-by: YeonJeong Kim <[email protected]>
@yjeong-k
Copy link
Contributor

수고많으셨습니다!!☺️

@yjeong-k yjeong-k merged commit edb504b into main Nov 12, 2023
1 check passed
@yjeong-k yjeong-k deleted the refactor/search branch November 12, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjeong-k yjeong-k yjeong-k approved these changes

@prime2do prime2do Awaiting requested review from prime2do

Assignees

@sukchan-0811 sukchan-0811

Labels
frontend Feature implementation for frontend user-interface Issues related to UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukchan-0811 @yjeong-k