Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Login viewmodel #93

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Test: Login viewmodel #93

merged 3 commits into from
Dec 9, 2023

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Dec 2, 2023

PR Title: Login viewmodel test

Related Issue(s):

  • Auth repository test가 에러때문에 실행이 안 되어서 주석처리 했습니다

PR Description:

  • Add Login viewmodel test
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:
  • Auth repository test가 에러때문에 실행이 안 되어서 주석처리 했습니다

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 added the test label Dec 2, 2023
@paul2126 paul2126 requested review from 89645321 and prime2do December 2, 2023 18:20
@89645321
Copy link
Contributor

89645321 commented Dec 3, 2023

coverage가 31 42 42로 뜹니다ㅠㅠ

@JH747 JH747 merged commit 1451dfa into main Dec 9, 2023
1 check passed
@JH747 JH747 deleted the test/login-viewmodel branch December 9, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JH747 JH747 JH747 approved these changes

@89645321 89645321 Awaiting requested review from 89645321

@prime2do prime2do Awaiting requested review from prime2do

Assignees

@paul2126 paul2126

@prime2do prime2do

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paul2126 @89645321 @JH747 @prime2do