Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Iteration 5 to main #18

Merged
merged 37 commits into from
Dec 5, 2023
Merged

Merge Iteration 5 to main #18

merged 37 commits into from
Dec 5, 2023

Conversation

Scripter36
Copy link
Contributor

PR Title: Merge Iteration 5 to main

Related Issue(s):

None

PR Description:

This pull request merges branches up to iteration 5, with integration tests.

Changes Included:
  • [v] Added new feature(s)
  • [v] Fixed identified bug(s)
  • [v] Updated relevant documentation

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as
    expected.
  • Code review comments have been addressed or clarified.

h9kwon and others added 30 commits November 23, 2023 15:08
@h9kwon
fix: quiz parsing error
23f0948
@minjoojeon @h9kwon
feat: orientation fix, disable AI buttons to prevent unexpected summa…
93b99f6 
…ry and quiz.
@h9kwon
fix: empty message error, book id error, streaming annotation, preven…
7beee52 
…t summary and quiz crash
@minjoojeon @h9kwon
feat: pull to refresh book list
1abb87c
@muffinsnip
feat: add intermediate summary progress tracking
b14c39c
@chaemin2001
feat: add book delete request; fix: create new connection to database…
7228ca3 
… per function call
@minjoojeon
refactor: add empty space on booklist bottom
f31f65b
@h9kwon @minjoojeon
feat: add delete book in UI
8918e34
@minjoojeon
fix: file type error, summary concatenated error, button unclickable …
5146fd7 
…due to message
@h9kwon
fix: bookList not deleted when sign out
7eca494
@minjoojeon @h9kwon
feat: add delete book alert
88af884
@h9kwon
feat: save progress, basic ai status; refactor: unnecessary UI, chang…
63c0fc7 
…e to Toast
@minjoojeon @h9kwon
feat: handle no internet connection, refactor: delete unnecessary UI
a4678dd
@h9kwon
fix: delayed progress upload, fix summary / quiz not stopping when ne…
9da73bd 
…w request came
@minjoojeon @h9kwon
refactor: move network check codes to NetworkStatusRepository, add ch…
b5c4b9a 
…eck to all network functions
@h9kwon @minjoojeon
feat: default book cover image and book card, resize cover image, lim…
0a12d88 
…it maximum length and prevent new line for book title and author
@minjoojeon
Refactor: delete unnecessary parameters, Fix: POST to GET
bc28a0d
@h9kwon
feat: preserve email input when go back
d7c9e68
@minjoojeon @h9kwon
feat: add user info to settings; fix: delayed viewer style change for…
1f8075f 
… font family
@h9kwon
feat: save content and image as file
2951227
@minjoojeon @h9kwon
feat: Viewer immersive mode, improve overall animation
ccfb085
@h9kwon
fix: quiz crash on error; feat: add change password to user data layer
31b51ea
@minjoojeon @h9kwon
feat: show summary preprocessing progress when overlay displayed; fix…
7b9adcd 
…: adding new line to the summary
@h9kwon
fix: remove black corner of default book cover, correctly apply font …
88ece09 
…weight
@minjoojeon @h9kwon
fix: match AI progress to UI design, unify page index / percent calcu…
afed96c 
…lation, remove stuck on fast viewer scroll
@h9kwon
fix: unintended new line in summary generating
4ed8897
@minjoojeon
feat: handle cases when summary and quiz failed during generation
3889d51
@h9kwon
test: BookRepository Unit tests
c4faba4
@Scripter36 @h9kwon
Test: add settingsView test, fix current tests to match implementation
6e641ea
@Scripter36
Merge branch 'main' into test/iteration5_integration
e650066
@Scripter36 Scripter36 merged commit 3f47ac2 into main Dec 5, 2023
2 checks passed
@Scripter36 Scripter36 deleted the test/iteration5_integration branch December 10, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minjoojeon minjoojeon minjoojeon approved these changes

@chaemin2001 chaemin2001 chaemin2001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Scripter36 @chaemin2001 @minjoojeon @h9kwon @muffinsnip