Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge final integration branch to main #20

Merged
merged 15 commits into from
Dec 10, 2023
Merged

Merge final integration branch to main #20

merged 15 commits into from
Dec 10, 2023

Conversation

Scripter36
Copy link
Contributor

PR Title: Merge final integration branch to main

Related Issue(s):

None

PR Description:

This PR merges final integration branch to main.

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as
    expected.
  • Code review comments have been addressed or clarified.

minjoojeon and others added 12 commits December 6, 2023 22:36
@minjoojeon @h9kwon
fix: apply paddings changed in viewer settings, switch positions of p…
eb32f04 
…lus and minus buttons in viewer settings; feat: set min/max value for viewer settings, change condition for ai from pages to number of characters;
@h9kwon
fix: apply paddings changed in viewer settings
32b42ce
@minjoojeon @h9kwon
refactor: apply Builder Pattern for ViewerStyle
17ae44e
@Scripter36
fix: fix delete account crash, match token life to backend, fix page …
4cdf13e 
…movement when move to another page
@h9kwon
feat: delete account
8948224
@minjoojeon
feat: change max char size of book title
07d1aa1
@h9kwon
fix: changed message for AI buttons
c7907f2
@Scripter36
test: add unit tests for all possible data layer classes
cf822a9
@Scripter36
fix: run ktlintFormat
9eff743
@Scripter36
fix: make instrumented test run again
e30f2a1
@Scripter36
fix: remove wildcard import
a5ff942
@muffinsnip
test: add unit test for proxy pattern; misc: add requirements file fo…
b36042e 
…r backend venv
muffinsnip
muffinsnip approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@muffinsnip muffinsnip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Scripter36 Scripter36 merged commit aaa0857 into main Dec 10, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h9kwon h9kwon h9kwon approved these changes

@muffinsnip muffinsnip muffinsnip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Scripter36 @muffinsnip @h9kwon @minjoojeon