Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle receiving a ChannelRemoved message from node #61

Open
nemanja-boric-sociomantic opened this issue Apr 27, 2018 · 2 comments
Open

Handle receiving a ChannelRemoved message from node #61

nemanja-boric-sociomantic opened this issue Apr 27, 2018 · 2 comments
Labels
type-bug

Comments

@nemanja-boric-sociomantic
Copy link
Contributor

In Neo Consume, it looks like that receiving the MessageType.ChannelRemoved will just hang the client:

https://github.com/sociomantic-tsunami/dmqproto/blob/v14.1.x/src/dmqproto/client/request/internal/Consume.d#L631-L634
@gavin-norman-sociomantic
Copy link

Oof.

@gavin-norman-sociomantic
Copy link

If possible, it'd be nice to add a test that Consumes a channel then removes it and checks that the Consume ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavin-norman-sociomantic @nemanja-boric-sociomantic