Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please fix security vulnerabilities #261

Closed
daniel-seitz opened this issue Nov 4, 2019 · 3 comments
Closed

please fix security vulnerabilities #261

daniel-seitz opened this issue Nov 4, 2019 · 3 comments

Comments

@daniel-seitz
Copy link

The following files still contain [email protected]

  • examples\echo\index.html
  • examples\express-3.x\index.html
  • examples\hapi\html\index.html
  • examples\multiplex\index.html

Since this contains a XSS vulnerability, please change to a newer version. See https://snyk.io/vuln/npm:jquery

Although these are just examples, it would be better to have it fixed.

Thank you,
Daniel

@daniel-seitz
Copy link
Author

Oh just found out that this is a dup of #257
The example were added to .npmignore by a previous commit but the build failed. I created a corresponding pr before finding this info #262, build is still failing.

Please fix and publish, thank you.

@brycekahle
Copy link
Contributor

I will merge your PR, but there is no need to publish a new package version which doesn't have any functional code changes.

@daniel-seitz
Copy link
Author

I agree as long as there will be a new version on the horizon. Also good spot about jsdelivr!
Thank you @brycekahle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants