Fixed double logs

sodadata · Feb 15, 2025 · 1b3cd0b · 1b3cd0b
1 parent 4a92875
commit 1b3cd0b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 14 deletions.
diff --git a/myds.yml b/myds.yml
diff --git a/soda-core/src/soda_core/common/logs.py b/soda-core/src/soda_core/common/logs.py
@@ -150,7 +150,7 @@ def debug(
         )
 
     def __str__(self) -> str:
-        return "\n".join([str(log) for log in self.logs])
+        return super().__str__() + "\n".join([str(log) for log in self.logs])
 
     def has_errors(self) -> bool:
         return any(log.level == ERROR for log in self.logs)
@@ -165,8 +165,7 @@ def get_errors(self) -> list[Log]:
         return [log for log in self.logs if log.level == ERROR]
 
     def __log(self, log: Log) -> None:
-        if log.level > DEBUG:
-            self.logs.append(log)
+        self.logs.append(log)
         self.__log_to_python_logging(log)
 
     def __log_to_python_logging(self, log: Log) -> None:

diff --git a/soda-core/src/soda_core/contracts/contract_verification.py b/soda-core/src/soda_core/contracts/contract_verification.py
@@ -323,7 +323,9 @@ def passed(self) -> bool:
         return not self.failed()
 
     def __str__(self) -> str:
-        log_lines: list[str] = [str(log) for log in self.logs.logs]
+        # TODO consider if the logs should be displayed here as well.
+        #  I ve removed them because they were printed double in the soda cli
+        log_lines: list[str] = []
 
         failed_count: int = 0
         not_evaluated_count: int = 0