fix counting performance (#204)

cdn/radash.esm.js

@@ -135,12 +135,12 @@ const alphabetical = (array, getter, dir = "asc") => {
   return array.slice().sort(dir === "desc" ? dsc : asc);
 };
 const counting = (list2, identity) => {
+  if (!list2)
+    return {};
   return list2.reduce((acc, item) => {
     const id = identity(item);
-    return {
-      ...acc,
-      [id]: (acc[id] ?? 0) + 1
-    };
+    acc[id] = (acc[id] ?? 0) + 1;
+    return acc;
   }, {});
 };
 const replace = (list2, newItem, match) => {

cdn/radash.js

@@ -138,12 +138,12 @@ var radash = (function (exports) {
     return array.slice().sort(dir === "desc" ? dsc : asc);
   };
   const counting = (list2, identity) => {
+    if (!list2)
+      return {};
     return list2.reduce((acc, item) => {
       const id = identity(item);
-      return {
-        ...acc,
-        [id]: (acc[id] ?? 0) + 1
-      };
+      acc[id] = (acc[id] ?? 0) + 1;
+      return acc;
     }, {});
   };
   const replace = (list2, newItem, match) => {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "radash",
-  "version": "10.3.0",
+  "version": "10.3.1",
   "description": "Functional utility library - modern, simple, typed, powerful",
   "main": "dist/cjs/index.cjs",
   "module": "dist/esm/index.mjs",

src/array.ts

@@ -161,12 +161,11 @@ export const counting = <T, TId extends string | number | symbol>(
   list: readonly T[],
   identity: (item: T) => TId
 ): Record<TId, number> => {
+  if (!list) return {} as Record<TId, number>
   return list.reduce((acc, item) => {
     const id = identity(item)
-    return {
-      ...acc,
-      [id]: (acc[id] ?? 0) + 1
-    }
+    acc[id] = (acc[id] ?? 0) + 1
+    return acc
   }, {} as Record<TId, number>)
 }
 

src/tests/array.test.ts

@@ -693,6 +693,10 @@ describe('array module', () => {
         Y: 2
       })
     })
+    test('does not error on bad input', () => {
+      _.counting(null as unknown as number[], x => x)
+      _.counting(undefined as unknown as number[], x => x)
+    })
   })
 
   describe('shift function', () => {