Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isObject should not be used by other functions in radash #409

Open
tiny-ant opened this issue May 29, 2024 · 1 comment · Fixed by radashi-org/radashi#18
Open

isObject should not be used by other functions in radash #409

tiny-ant opened this issue May 29, 2024 · 1 comment · Fixed by radashi-org/radashi#18

Comments

@tiny-ant
Copy link

assign

since isObject(Object.create(null)) returns false, functions in radash like assign or keys do not match the real case in some business. It's a common situation that we should create a pure object without keys like toString to keep something accurate.
It's a better solution to provide another function util like isPlainObject.

@aleclarson
Copy link

Hi @tiny-ant, this issue is fixed in radashi@beta today (see #18). An official release is pending. We'd love to have you participate in the discussion and/or development of the radashi-org/radashi fork. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants