Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPromise misleading in type definitions, it should return value is PromiseLike<> #418

Open
anion155 opened this issue Jul 26, 2024 · 1 comment

Comments

@anion155
Copy link

isPromise doesn't really checks for value to be instance of Promise class, it checks if value is promise like, so it should return correct typings

It should be

export const isPromise = (value: any): value is PromiseLike<any> => {
@aleclarson
Copy link

Hey @anion155. Over at the Radashi fork, this issue is being tracked in https://github.com/orgs/radashi-org/discussions/73. We should have this resolved in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants