-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing handling of small number of input reads #26
Comments
@mr-eyes thanks for reporting this. This error seem to be fixed in the newest version of plass. Could you please retry it with the newest version? |
@martin-steinegger I think I'm already using the latest release via bioconda channel latest_release. |
@martin-steinegger I tried the latest static linux build and it's fixed, the version of it is the commit hash Thank you, |
UPDATE: The issue still exists if the number of reads is 1. It enters an infinite loop when trying to assemble a single read (Which logically makes sense) but the problem in the infinite loop. |
Another noticed behavior regarding the multiprocessing, the internal clustering commands that runs at the end of the assembly to extract the representative sequences does not inherit the user-defined
|
@mr-eyes The nuclassemble workflow itself is heavily under development at the moment. I fixed the problem that the --threads value was not passed to the redundancy workflow in general. But I guess the |
@AnnSeidel Actually not, my first run was --threads 32. And the plass version of the current two issues is Integrating the clustering at the end of the pipeline is nice, and it would not be a problem running To summarize this thread, we have two issues here.
|
Expected Behavior
Throw an exception or end the program if the number of reads is small that it will fail to be assembled.
Current Behavior
Entered an infinite loop running on 24 threads (Different from the provided --threads parameter).
Steps to Reproduce (for bugs)
Create fastq files
R1.fastq
R2.fastq
Plass Output (for bugs)
plass nuclassemble R1.fastq R2.fastq assembled.fa tmp --threads 2 -v 3
Plass Output Log
Your Environment
Include as many relevant details about the environment you experienced the bug in.
Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz
64 GB RAM -Intel(R) Core(TM) i7-4510U CPU @ 2.00GHz
16 GB RAMThe text was updated successfully, but these errors were encountered: