Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Lab 1 #3

Open
ana-oprescu opened this issue Sep 20, 2017 · 0 comments
Open

Feedback Lab 1 #3

ana-oprescu opened this issue Sep 20, 2017 · 0 comments

Comments

@ana-oprescu
Copy link

Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Bonus Exercise 9 Comments Bonus Exercise 10 Comments Total
7 No timing, no discussion about selection 7 You are not checking mathematical facts 7 No timing, no discussion about selection 9 Nice solution and discussion: No timing 9 No timing 8 The counter example must be a number not a list of primes 8 You could have added some testable properties for helper functions (e.g., turning digits to integers and back); you could also generate the invalid testcases; you do not check for invalid card numbers that fail all card types, either due to prefix or length. 6 -> issues 0   0   7.625
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant