Feedback Lab 6

[ana-oprescu]

Exercise 1	Comments	Exercise 2	Comments	Exercise 3	Comments	Exercise 4	Comments	Exercise 5	Comments	Exercise 6	Comments	Exercise 7	Comments	Exercise 8	Comments	Total
9	Good job. Maybe a faster version could be implemented using Data.Bits.shiftR	6	Tests are well implemented. However, you are not considering memory as a metric. A deeper analysis of your findings, where you mention means, stdev, grow rate, etc. is missing	10	Excellent	7	Very good, can be improved by continuing the test even after finding the first false positive, and printing all the found false positives	7	Analysis is ok. In your tests you are not taking into account that a Carmichael number N fools the Fermat test if you check aˆ(N−1) for some a that is coprime with N. An analysis/test on that direction is needed	10	->issues	8	->issues	0	->issues	8.142857143