Feedback Lab 6

[ana-oprescu]

Exercise 1	Comments	Exercise 2	Comments	Exercise 3	Comments	Exercise 4	Comments	Exercise 5	Comments	Exercise 6	Comments	Exercise 7	Comments	Exercise 8	Comments	Total
9	Great job. Maybe a faster version could be implemented using Data.Bits.shiftR	7	Testing is ok, however, variations of workload would be really valuable	9	Why not starting in 4? Since you know that 2 and 3 are not composite	5	Implementation is buggy. Check (Main> checkComposites 5 (composites2 1000)** Exception: answers_lab6_WG_5.hs:(61,1)-(67,49): Non-exhaustive patterns in function checkComposites). IT can be improved by continuing the test even after finding the first false positive, and printing all the found false positives	6	Analysis is ok. But you are not discussing Charmichael numbers. In your analysis, you are not taking into account that a Carmichael number N fools the Fermat test if you check aˆ(N−1) for some a that is coprime with N. An analysis on that direction is needed	6	Issues	6	Issues	0