Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Lab 6 #9

Open
ana-oprescu opened this issue Oct 23, 2017 · 0 comments
Open

Feedback Lab 6 #9

ana-oprescu opened this issue Oct 23, 2017 · 0 comments

Comments

@ana-oprescu
Copy link

Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Total
9 Good job. Maybe a faster version could be implemented using Data.Bits.shiftR 8 Good analysis. However some statistical analysis would make it better 10 Excellent 8 Good job. The analysis is well written. Can be improved by continuing the test even after finding the first false positive, and printing all the found false positives 6 Analysis is ok. In your analysis you are not taking into account that a Carmichael number N fools the Fermat test if you check aˆ(N−1) for some a that is coprime with N. An analysis/test on that direction is needed 10 ->issues 8 ->issues 10 ->issues 9.428571429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant