address review

software-mansion-labs · Mar 18, 2024 · 4b764ea · 4b764ea
1 parent 79977f2
commit 4b764ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/libs/actions/TaxRate.ts b/src/libs/actions/TaxRate.ts
@@ -53,7 +53,6 @@ function createPolicyTax(policyID: string, taxRate: TaxRate) {
                             [taxRate.code]: {
                                 ...taxRate,
                                 pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
-                                errors: null,
                             },
                         },
                     },
@@ -69,6 +68,7 @@ function createPolicyTax(policyID: string, taxRate: TaxRate) {
                         taxes: {
                             [taxRate.code]: {
                                 errors: null,
+                                pendingAction: null,
                             },
                         },
                     },

diff --git a/src/types/onyx/Policy.ts b/src/types/onyx/Policy.ts
@@ -39,7 +39,7 @@ type TaxRate = OnyxCommon.OnyxValueWithOfflineFeedback<{
     /** The value of the tax rate as percentage. */
     value: string;
 
-    /** The code associated with the tax rate. */
+    /** The code associated with the tax rate. If a tax is created in old dot, code field is undefined */
     code?: string;
 
     /** This contains the tax name and tax value as one name */